Mike McCormack : msi: Avoid an unnecessary strdup.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Oct 10 06:50:39 CDT 2006


Module: wine
Branch: master
Commit: 47949afc359f1512c574966548f3afa2d3066cee
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=47949afc359f1512c574966548f3afa2d3066cee

Author: Mike McCormack <mike at codeweavers.com>
Date:   Tue Oct 10 19:19:56 2006 +0900

msi: Avoid an unnecessary strdup.

---

 dlls/msi/msiquery.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/msiquery.c b/dlls/msi/msiquery.c
index ff8aa42..824a5be 100644
--- a/dlls/msi/msiquery.c
+++ b/dlls/msi/msiquery.c
@@ -390,11 +390,10 @@ UINT MSI_ViewFetch(MSIQUERY *query, MSIR
 
             if( type & MSITYPE_STRING )
             {
-                LPWSTR sval;
+                LPCWSTR sval;
 
-                sval = MSI_makestring( query->db, ival );
+                sval = msi_string_lookup_id( query->db->strings, ival );
                 MSI_RecordSetStringW( rec, i, sval );
-                msi_free( sval );
             }
             else
             {




More information about the wine-cvs mailing list