Alexandre Julliard : crypt32: Comment out an unreliable test.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Sep 12 09:35:07 CDT 2006


Module: wine
Branch: master
Commit: 8e06fc4c0dc8e5886da79dd10f2f8e3052b3602a
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=8e06fc4c0dc8e5886da79dd10f2f8e3052b3602a

Author: Alexandre Julliard <julliard at winehq.org>
Date:   Tue Sep 12 14:45:48 2006 +0200

crypt32: Comment out an unreliable test.

---

 dlls/crypt32/tests/encode.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/dlls/crypt32/tests/encode.c b/dlls/crypt32/tests/encode.c
index 50e3725..b7d5341 100644
--- a/dlls/crypt32/tests/encode.c
+++ b/dlls/crypt32/tests/encode.c
@@ -199,7 +199,7 @@ static void test_decodeInt(DWORD dwEncod
     static const BYTE bigInt[] = { 2, 5, 0xff, 0xfe, 0xff, 0xfe, 0xff };
     static const BYTE testStr[] = { 0x16, 4, 't', 'e', 's', 't' };
     static const BYTE longForm[] = { 2, 0x81, 0x01, 0x01 };
-    static const BYTE bigBogus[] = { 0x02, 0x84, 0x01, 0xff, 0xff, 0xf9 };
+    /* static const BYTE bigBogus[] = { 0x02, 0x84, 0x01, 0xff, 0xff, 0xf9 }; */
     BYTE *buf = NULL;
     DWORD bufSize = 0;
     int i;
@@ -324,10 +324,12 @@ static void test_decodeInt(DWORD dwEncod
     /* This will try to decode the buffer and overflow it, check that it's
      * caught.
      */
+#if 0  /* a large buffer isn't guaranteed to crash, it depends on memory allocation order */
     ret = CryptDecodeObjectEx(dwEncoding, X509_MULTI_BYTE_INTEGER, bigBogus,
      0x01ffffff, CRYPT_DECODE_ALLOC_FLAG, NULL, (BYTE *)&buf, &bufSize);
     ok(!ret && GetLastError() == STATUS_ACCESS_VIOLATION,
      "Expected STATUS_ACCESS_VIOLATION, got %08lx\n", GetLastError());
+#endif
 }
 
 static const BYTE bin18[] = {0x0a,0x01,0x01};




More information about the wine-cvs mailing list