Aric Stewart : ole32: Storage optimization.

Alexandre Julliard julliard at wine.codeweavers.com
Thu Apr 5 06:42:52 CDT 2007


Module: wine
Branch: master
Commit: 6230222aab6caacdcd5673c3c4c896fc3e80643d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6230222aab6caacdcd5673c3c4c896fc3e80643d

Author: Aric Stewart <aric at codeweavers.com>
Date:   Wed Apr  4 13:15:28 2007 -0500

ole32: Storage optimization.

We do not need to unmap and remap all the victim pages with every
resize as they are simply a cache. Provides significant speedup for
saving large storage files.

---

 dlls/ole32/stg_bigblockfile.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/dlls/ole32/stg_bigblockfile.c b/dlls/ole32/stg_bigblockfile.c
index 83454d4..4f22207 100644
--- a/dlls/ole32/stg_bigblockfile.c
+++ b/dlls/ole32/stg_bigblockfile.c
@@ -114,6 +114,7 @@ static MappedPage* BIGBLOCKFILE_CreatePage(LPBIGBLOCKFILE This,
 static DWORD     BIGBLOCKFILE_GetProtectMode(DWORD openFlags);
 static BOOL      BIGBLOCKFILE_FileInit(LPBIGBLOCKFILE This, HANDLE hFile);
 static BOOL      BIGBLOCKFILE_MemInit(LPBIGBLOCKFILE This, ILockBytes* plkbyt);
+static void      BIGBLOCKFILE_DeleteList(LPBIGBLOCKFILE This, MappedPage *list);
 
 /* Note that this evaluates a and b multiple times, so don't
  * pass expressions with side effects. */
@@ -356,7 +357,15 @@ void BIGBLOCKFILE_SetSize(LPBIGBLOCKFILE This, ULARGE_INTEGER newSize)
   TRACE("from %u to %u\n", This->filesize.u.LowPart, newSize.u.LowPart);
   /*
    * unmap all views, must be done before call to SetEndFile
+   *
+   * Just ditch the victim list because there is no guarentee we will need them
+   * and it is not worth the performance hit to unmap and remap them all.
    */
+  BIGBLOCKFILE_DeleteList(This, This->victimhead);
+  This->victimhead = NULL;
+  This->victimtail = NULL;
+  This->num_victim_pages = 0;
+
   BIGBLOCKFILE_UnmapAllMappedPages(This);
 
   if (This->fileBased)




More information about the wine-cvs mailing list