Aric Stewart : shell32: SHGFI_EXETYPE flag should have the files returning 0 if they are DLL images .

Alexandre Julliard julliard at wine.codeweavers.com
Thu Apr 19 05:24:20 CDT 2007


Module: wine
Branch: master
Commit: dac19db358a3b77b1c5a2fd3253bf7700f61bbc7
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=dac19db358a3b77b1c5a2fd3253bf7700f61bbc7

Author: Aric Stewart <aric at codeweavers.com>
Date:   Wed Apr 18 13:11:47 2007 -0500

shell32: SHGFI_EXETYPE flag should have the files returning 0 if they are DLL images.

---

 dlls/shell32/shell32_main.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c
index 70db342..ea4b510 100644
--- a/dlls/shell32/shell32_main.c
+++ b/dlls/shell32/shell32_main.c
@@ -275,6 +275,9 @@ static DWORD shgfi_get_exe_type(LPCWSTR szFullPath)
         SetFilePointer( hfile, mz_header.e_lfanew, NULL, SEEK_SET );
         ReadFile( hfile, &nt, sizeof(nt), &len, NULL );
         CloseHandle( hfile );
+        /* DLL files are not executable and should return 0 */
+        if (nt.FileHeader.Characteristics & IMAGE_FILE_DLL)
+            return 0;
         if (nt.OptionalHeader.Subsystem == IMAGE_SUBSYSTEM_WINDOWS_GUI)
         {
              return IMAGE_NT_SIGNATURE | 




More information about the wine-cvs mailing list