Juan Lang : crypt32: Get rid of bogus check and improve traces for unexpected alt name entry types .

Alexandre Julliard julliard at wine.codeweavers.com
Fri Aug 3 08:04:31 CDT 2007


Module: wine
Branch: master
Commit: 0cb6148422e455406316ea55cef66adc99c0fd03
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0cb6148422e455406316ea55cef66adc99c0fd03

Author: Juan Lang <juan.lang at gmail.com>
Date:   Thu Aug  2 09:47:19 2007 -0700

crypt32: Get rid of bogus check and improve traces for unexpected alt name entry types.

---

 dlls/crypt32/decode.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c
index 022c912..7d7634a 100644
--- a/dlls/crypt32/decode.c
+++ b/dlls/crypt32/decode.c
@@ -2111,11 +2111,6 @@ static BOOL WINAPI CRYPT_AsnDecodeAltNameEntry(DWORD dwCertEncodingType,
         SetLastError(CRYPT_E_ASN1_CORRUPT);
         return FALSE;
     }
-    if ((pbEncoded[0] & ASN_FLAGS_MASK) != ASN_CONTEXT)
-    {
-        SetLastError(CRYPT_E_ASN1_BADTAG);
-        return FALSE;
-    }
     lenBytes = GET_LEN_BYTES(pbEncoded[1]);
     if (1 + lenBytes > cbEncoded)
     {
@@ -2138,16 +2133,18 @@ static BOOL WINAPI CRYPT_AsnDecodeAltNameEntry(DWORD dwCertEncodingType,
             /* FIXME: decode as OID */
         case 0: /* otherName */
         case 4: /* directoryName */
-            FIXME("stub\n");
+            FIXME("%d: stub\n", pbEncoded[0] & ASN_TYPE_MASK);
             SetLastError(CRYPT_E_ASN1_BADTAG);
             ret = FALSE;
             break;
         case 3: /* x400Address, unimplemented */
         case 5: /* ediPartyName, unimplemented */
+            TRACE("type %d unimplemented\n", pbEncoded[0] & ASN_TYPE_MASK);
             SetLastError(CRYPT_E_ASN1_BADTAG);
             ret = FALSE;
             break;
         default:
+            TRACE("type %d bad\n", pbEncoded[0] & ASN_TYPE_MASK);
             SetLastError(CRYPT_E_ASN1_CORRUPT);
             ret = FALSE;
         }




More information about the wine-cvs mailing list