James Hawkins : msi: Properly release the record.
Alexandre Julliard
julliard at winehq.org
Wed Dec 12 09:29:18 CST 2007
Module: wine
Branch: master
Commit: 80894d1c522d715fe1e874643361ea568af99b7b
URL: http://source.winehq.org/git/wine.git/?a=commit;h=80894d1c522d715fe1e874643361ea568af99b7b
Author: James Hawkins <truiken at gmail.com>
Date: Tue Dec 11 21:46:32 2007 -0600
msi: Properly release the record.
---
dlls/msi/package.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/dlls/msi/package.c b/dlls/msi/package.c
index 04633f2..1286641 100644
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -123,15 +123,16 @@ UINT msi_clone_properties(MSIPACKAGE *package)
break;
rc = MSI_DatabaseOpenViewW(package->db, Insert, &view2);
- if (rc!= ERROR_SUCCESS)
+ if (rc != ERROR_SUCCESS)
+ {
+ msiobj_release(&row->hdr);
continue;
+ }
- rc = MSI_ViewExecute(view2, row);
+ MSI_ViewExecute(view2, row);
MSI_ViewClose(view2);
msiobj_release(&view2->hdr);
-
- if (rc == ERROR_SUCCESS)
- msiobj_release(&row->hdr);
+ msiobj_release(&row->hdr);
}
MSI_ViewClose(view);
More information about the wine-cvs
mailing list