Michael Stefaniuc : wldap32: Missing HeapFree on error path ( found by Smatch).

Alexandre Julliard julliard at wine.codeweavers.com
Tue Feb 13 11:07:50 CST 2007


Module: wine
Branch: master
Commit: c6c68bf304e4aa2ad66024fb6d64b8250ddb7341
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c6c68bf304e4aa2ad66024fb6d64b8250ddb7341

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Feb 13 00:02:34 2007 +0100

wldap32: Missing HeapFree on error path (found by Smatch).

---

 dlls/wldap32/page.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/dlls/wldap32/page.c b/dlls/wldap32/page.c
index cfea875..cc1d0af 100644
--- a/dlls/wldap32/page.c
+++ b/dlls/wldap32/page.c
@@ -114,7 +114,10 @@ static ULONG create_page_control( ULONG
 
     ctrl = HeapAlloc( GetProcessHeap(), 0, sizeof(LDAPControlW) );
     if (!ctrl)
+    {
+        HeapFree( GetProcessHeap(), 0, val );
         return WLDAP32_LDAP_NO_MEMORY;
+    }
 
     ctrl->ldctl_oid = strAtoW( LDAP_PAGED_RESULT_OID_STRING );
     ctrl->ldctl_value.bv_len = len;




More information about the wine-cvs mailing list