Chris Robinson : quartz: Don't use uninitialized memory in ACMWrapper.

Alexandre Julliard julliard at wine.codeweavers.com
Mon Feb 19 07:02:12 CST 2007


Module: wine
Branch: master
Commit: a512b9abb57129ab40f7bb1484d3536699760741
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a512b9abb57129ab40f7bb1484d3536699760741

Author: Chris Robinson <chris.kcat at gmail.com>
Date:   Sat Feb 17 22:17:32 2007 -0800

quartz: Don't use uninitialized memory in ACMWrapper.

---

 dlls/quartz/acmwrapper.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/quartz/acmwrapper.c b/dlls/quartz/acmwrapper.c
index 62f0020..4b2d143 100644
--- a/dlls/quartz/acmwrapper.c
+++ b/dlls/quartz/acmwrapper.c
@@ -91,7 +91,7 @@ static HRESULT ACMWrapper_ProcessSampleData(TransformFilterImpl* pTransformFilte
 	This->current_size += copy_size;
 	offset += copy_size;
 
-	if (offset == size)
+	if (offset >= size)
 	    stop = TRUE;
 	if (This->current_size < This->max_size)
 	    break;
@@ -256,8 +256,8 @@ HRESULT ACMWrapper_create(IUnknown * pUnkOuter, LPVOID * ppv)
 
     /* Note: This memory is managed by the transform filter once created */
     This = CoTaskMemAlloc(sizeof(ACMWrapperImpl));
+    ZeroMemory(This, sizeof(ACMWrapperImpl));
 
-    This->has = 0;
     This->reinit_codec = TRUE;
 
     hr = TransformFilter_Create(&(This->tf), &CLSID_ACMWrapper, &ACMWrapper_FuncsTable);




More information about the wine-cvs mailing list