Chris Robinson : quartz: Don't release filters when they connect.

Alexandre Julliard julliard at wine.codeweavers.com
Wed Feb 21 06:00:57 CST 2007


Module: wine
Branch: master
Commit: 5a8ee37191abcee35c2dc2475ed9b03f7b0500f4
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5a8ee37191abcee35c2dc2475ed9b03f7b0500f4

Author: Chris Robinson <chris.kcat at gmail.com>
Date:   Tue Feb 20 12:35:19 2007 -0800

quartz: Don't release filters when they connect.

---

 dlls/quartz/filtergraph.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index b894781..c301220 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -815,7 +815,6 @@ static HRESULT WINAPI GraphBuilder_Connect(IGraphBuilder *iface,
             }
             while (++i < nb) IPin_Release(ppins[i]);
             CoTaskMemFree(ppins);
-            IBaseFilter_Release(pfilter);
             IPin_Release(ppinfilter);
             break;
         }
@@ -1082,7 +1081,7 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface,
         }
         IGraphBuilder_RemoveFilter(iface, psplitter);
         IBaseFilter_Release(psplitter);
-        ppinsplitter = NULL;
+        psplitter = NULL;
     }
 
     /* Render all output pin of the splitter by calling IGraphBuilder_Render on each of them */
@@ -1104,10 +1103,6 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface,
         hr = (partial ? VFW_S_PARTIAL_RENDER : S_OK);
     }
 
-    if (psplitter)
-        IBaseFilter_Release(psplitter);
-    IBaseFilter_Release(preader);
-
     return hr;
 }
 




More information about the wine-cvs mailing list