appdb/. testResults.php

[WineHQ]

ChangeSet ID:	30862
CVSROOT:	/opt/cvs-commit
Module name:	appdb
Changes by:	wineowner at winehq.org	2007/01/06 23:15:33

Modified files:
	.              : testResults.php 

Log message:
	Alexander Nicolaysen Sørnes <alex at thehandofagony.com>
	Chris Morgan <cmorgan at alum.wpi.edu>
	Fix testResults.php to work with the filter system

Patch: http://cvs.winehq.org/patch.py?id=30862

Old revision  New revision  Changes     Path
 1.23          1.24          +11 -8      appdb/testResults.php

Index: appdb/testResults.php
diff -u -p appdb/testResults.php:1.23 appdb/testResults.php:1.24
--- appdb/testResults.php:1.23	7 Jan 2007  5:15:33 -0000
+++ appdb/testResults.php	7 Jan 2007  5:15:33 -0000
@@ -41,11 +41,11 @@ if ($aClean['sSub'])
             }
             if($aClean['sSub'] == 'Submit')
             {
-	        $oTest->create();
+                $oTest->create();
             } else if($aClean['sSub'] == 'Resubmit')
             {
                 $oTest->update(true);
-	        $oTest->ReQueue();
+                $oTest->ReQueue();
             }
             util_redirect_and_exit($_SERVER['PHP_SELF']);
         } else 
@@ -57,17 +57,17 @@ if ($aClean['sSub'])
     // Delete test results
     if ($aClean['sSub'] == 'Delete')
     {
-        if(is_numeric($aClean['iTestingId']))
+        if($aClean['iTestingId'])
         {
             $oTest = new testData($aClean['iTestingId']);
             $oTest->delete();
         }
-        
+
         util_redirect_and_exit($_SERVER['PHP_SELF']);
     }
 
     // is this an old test?
-    if(is_numeric($aClean['iTestingId']))
+    if($aClean['iTestingId'])
     {
         // make sure the user has permission to view this test result
         $oVersion = new Version($oTest->iVersionId);
@@ -77,11 +77,13 @@ if ($aClean['sSub'])
         {
             util_show_error_page_and_exit("Insufficient privileges.");
         } else
-        $oVersion = new Version($oTest->iVersionId);
+        {
+            $oVersion = new Version($oTest->iVersionId);
+        }
     } else
     { 
         $oTest->iVersionId = $aClean['iVersionId'];
-        $oVersion = new Version($aClean['iVersionId']);       
+        $oVersion = new Version($aClean['iVersionId']);
         $oTest->sQueued = "new";
     }
     if ($aClean['sSub'] == 'view')
@@ -105,7 +107,8 @@ if ($aClean['sSub'])
             apidb_header("Edit test results for ".$sVersionInfo);
             break;
         default:
-            apidb_header("Edit test results for ");
+            util_show_error_page_and_exit('$oTest->sQueued of \''.$oTest->sQueued."'is invalid");
+            break;
         }
         echo '<form name="sQform" action="'.$_SERVER['PHP_SELF'].'" method="post" enctype="multipart/form-data">',"\n";