Mike McCormack : msi: Add todos around tests that aren't being run yet, but will fail.

Alexandre Julliard julliard at wine.codeweavers.com
Fri Jan 26 07:47:05 CST 2007


Module: wine
Branch: master
Commit: 595983f4983ddb76b5e606a4e813beaa990d9b15
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=595983f4983ddb76b5e606a4e813beaa990d9b15

Author: Mike McCormack <mike at codeweavers.com>
Date:   Fri Jan 26 21:14:25 2007 +0900

msi: Add todos around tests that aren't being run yet, but will fail.

---

 dlls/msi/tests/iface.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/tests/iface.c b/dlls/msi/tests/iface.c
index 556e6f5..d7dc640 100644
--- a/dlls/msi/tests/iface.c
+++ b/dlls/msi/tests/iface.c
@@ -63,6 +63,7 @@ static void test_msi_dispid(void)
         return;
     }
 
+    todo_wine {
     ok( get_dispid( disp, "OpenPackage" ) == 2, "dispid wrong\n");
     ok( get_dispid( disp, "OpenProduct" ) == 3, "dispid wrong\n");
     ok( get_dispid( disp, "OpenDatabase" ) == 4, "dispid wrong\n");
@@ -118,6 +119,7 @@ static void test_msi_dispid(void)
     ok( get_dispid( disp, "PatchesEx" ) == 55, "dispid wrong\n");
 
     ok( get_dispid( disp, "ExtractPatchXMLData" ) == 57, "dispid wrong\n");
+    }
 
     /* MSDN claims the following functions exist but IDispatch->GetIDsOfNames disagrees */
     if (0)
@@ -166,7 +168,12 @@ static void test_msi_invoke(void)
 
     r = IDispatch_Invoke( installer, dispid, &IID_NULL, 0,
                           DISPATCH_METHOD, &param, &result, NULL, NULL);
-    ok( r == S_OK, "dispatch failed %08x\n", r);
+    todo_wine ok( r == S_OK, "dispatch failed %08x\n", r);
+    if (FAILED(r))
+    {
+        skip( "failed to create record\n");
+        return;
+    }
 
     ok( V_VT(&result) == VT_DISPATCH, "type wrong\n");
 




More information about the wine-cvs mailing list