James Hawkins : msi: Properly delete the columns view.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Jul 24 07:06:17 CDT 2007


Module: wine
Branch: master
Commit: 8a7690c1519189d49d7fc4c6d4a2bd01462fddaf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=8a7690c1519189d49d7fc4c6d4a2bd01462fddaf

Author: James Hawkins <truiken at gmail.com>
Date:   Mon Jul 23 19:19:15 2007 -0700

msi: Properly delete the columns view.

---

 dlls/msi/alter.c |    2 +-
 dlls/msi/table.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/alter.c b/dlls/msi/alter.c
index 734aaba..cfb8ab4 100644
--- a/dlls/msi/alter.c
+++ b/dlls/msi/alter.c
@@ -129,7 +129,7 @@ static UINT alter_add_column(MSIALTERVIEW *av)
                                  colnum, av->colinfo->column,
                                  av->colinfo->type, (av->hold == 1));
 
-    msiobj_release(&columns->hdr);
+    columns->ops->delete(columns);
     return r;
 }
 
diff --git a/dlls/msi/table.c b/dlls/msi/table.c
index b65494a..745712a 100644
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -1686,7 +1686,7 @@ static UINT TABLE_add_ref(struct tagMSIVIEW *view)
 static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT number)
 {
     MSITABLEVIEW *tv = (MSITABLEVIEW*)view;
-    MSIRECORD *rec;
+    MSIRECORD *rec = NULL;
     MSIVIEW *columns = NULL;
     UINT row, r;
 
@@ -1713,7 +1713,7 @@ static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT num
 
 done:
     msiobj_release(&rec->hdr);
-    if (columns) msiobj_release(&columns->hdr);
+    if (columns) columns->ops->delete(columns);
     return r;
 }
 




More information about the wine-cvs mailing list