appdb/. screenshots.php
WineHQ
wineowner at wine.codeweavers.com
Sat Jun 16 16:16:12 CDT 2007
ChangeSet ID: 31215
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner at winehq.org 2007/06/16 16:16:12
Modified files:
. : screenshots.php
Log message:
Chris Morgan <cmorgan at alum.wpi.edu>
Properly close all of the html frames we opened with html_frame_start(). Fixes a bug where the
back link appears inside of a frame and the page rendering time appears in an odd red bar at
the bottom of the page
Patch: http://cvs.winehq.org/patch.py?id=31215
Old revision New revision Changes Path
1.45 1.46 +6 -2 appdb/screenshots.php
Index: appdb/screenshots.php
diff -u -p appdb/screenshots.php:1.45 appdb/screenshots.php:1.46
--- appdb/screenshots.php:1.45 16 Jun 2007 21:16:12 -0000
+++ appdb/screenshots.php 16 Jun 2007 21:16:12 -0000
@@ -69,6 +69,9 @@ if($hResult && mysql_num_rows($hResult))
echo "<div align=center><table><tr>\n";
while($oRow = mysql_fetch_object($hResult))
{
+ // if the current version changed then update the current version
+ // and close the previous html frame if this isn't the
+ // first frame
if(!$aClean['iVersionId'] && $oRow->versionId != $currentVersionId)
{
if($currentVersionId)
@@ -77,7 +80,7 @@ if($hResult && mysql_num_rows($hResult))
echo html_frame_end();
$c=1;
}
- $currentVersionId=$oRow->versionId;
+ $currentVersionId = $oRow->versionId;
echo html_frame_start("Version ".Version::lookup_name($currentVersionId));
echo "<div align=center><table><tr>\n";
}
@@ -104,7 +107,8 @@ if($hResult && mysql_num_rows($hResult))
}
echo "</tr></table></div><br />\n";
- echo html_frame_end("Click thumbnail to view image in new window.");
+ echo html_frame_end(); // close the current version we are displaying
+ echo html_frame_end(); // close the "Screenshot Gallary..." html frame
} else {
echo "<p align=\"center\">There are currently no screenshots for the selected version of this application.";
echo "<br />Please consider submitting a screenshot for the selected version yourself.</p>";
More information about the wine-cvs
mailing list