Thomas Weidenmueller : shell32: Use SHStrDupW in IShellFolder2:: GetDetailsOf to allocate returned string.

Alexandre Julliard julliard at winehq.org
Fri Nov 2 08:10:22 CDT 2007


Module: wine
Branch: master
Commit: 4c516e63d31a846c41b77b5ecf8d84a5af268f34
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=4c516e63d31a846c41b77b5ecf8d84a5af268f34

Author: Thomas Weidenmueller <thomas at reactsoft.com>
Date:   Thu Nov  1 16:02:57 2007 -0600

shell32: Use SHStrDupW in IShellFolder2::GetDetailsOf to allocate returned string.

---

 dlls/shell32/recyclebin.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/shell32/recyclebin.c b/dlls/shell32/recyclebin.c
index a1ca9a6..441068f 100644
--- a/dlls/shell32/recyclebin.c
+++ b/dlls/shell32/recyclebin.c
@@ -439,8 +439,7 @@ static HRESULT WINAPI RecycleBin_GetDetailsOf(IShellFolder2 *iface, LPCITEMIDLIS
     }
     
     pDetails->str.uType = STRRET_WSTR;
-    pDetails->str.u.pOleStr = StrDupW(buffer);
-    return (pDetails->str.u.pOleStr != NULL ? S_OK : E_OUTOFMEMORY);
+    return SHStrDupW(buffer, &pDetails->str.u.pOleStr);
 }
 
 static HRESULT WINAPI RecycleBin_MapColumnToSCID(IShellFolder2 *iface, UINT iColumn, SHCOLUMNID *pscid)




More information about the wine-cvs mailing list