Alistair Leslie-Hughes : msxml3: Enable test for bad argument / fix memory leak.
Alexandre Julliard
julliard at winehq.org
Tue Nov 13 08:34:50 CST 2007
Module: wine
Branch: master
Commit: fad20c9ce0d9d26526cc636ca9d71c11acfbff4e
URL: http://source.winehq.org/git/wine.git/?a=commit;h=fad20c9ce0d9d26526cc636ca9d71c11acfbff4e
Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date: Sun Nov 11 22:36:07 2007 +1100
msxml3: Enable test for bad argument / fix memory leak.
---
dlls/msxml3/tests/domdoc.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index d2cd09c..ecedf06 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -405,12 +405,9 @@ static void test_domdoc( void )
ok( b == VARIANT_TRUE, "failed to load XML string\n");
SysFreeString( str );
- /* try with a null out pointer - crashes */
- if (0)
- {
- r = IXMLDOMDocument_get_documentElement( doc, NULL );
- ok( r == S_OK, "should be no document element\n");
- }
+ /* try with a null out pointer */
+ r = IXMLDOMDocument_get_documentElement( doc, NULL );
+ ok( r == E_INVALIDARG, "should be no document element\n");
/* check if nodename is correct */
r = IXMLDOMDocument_get_nodeName( doc, NULL );
@@ -704,6 +701,7 @@ todo_wine
r = IXMLDOMNode_get_baseName( node, &str );
ok( r == S_OK, "get_baseName returned wrong code\n");
ok( lstrcmpW(str,szdl) == 0, "basename was wrong\n");
+ SysFreeString( str );
r = IXMLDOMNode_get_nodeValue( node, &var );
ok( r == S_OK, "returns %08x\n", r );
More information about the wine-cvs
mailing list