Mikolaj Zalewski : comdlg32: NULL name in PRINTDLG_SetUpPrinterListComboA is correct so don' t print a FIXME.
Alexandre Julliard
julliard at winehq.org
Tue Oct 16 07:59:50 CDT 2007
Module: wine
Branch: master
Commit: cdcdbe9b68daa443c63310aa0b08d86f3d11faca
URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdcdbe9b68daa443c63310aa0b08d86f3d11faca
Author: Mikolaj Zalewski <mikolajz at google.com>
Date: Mon Oct 15 18:42:42 2007 -0700
comdlg32: NULL name in PRINTDLG_SetUpPrinterListComboA is correct so don't print a FIXME.
---
dlls/comdlg32/printdlg.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/dlls/comdlg32/printdlg.c b/dlls/comdlg32/printdlg.c
index 8e334c3..490a794 100644
--- a/dlls/comdlg32/printdlg.c
+++ b/dlls/comdlg32/printdlg.c
@@ -133,8 +133,9 @@ INT PRINTDLG_SetUpPrinterListComboA(HWND hDlg, UINT id, LPCSTR name)
char buf[260];
DWORD dwBufLen = sizeof(buf);
- FIXME("Can't find '%s' in printer list so trying to find default\n",
- name);
+ if (name != NULL)
+ WARN("Can't find %s in printer list so trying to find default\n",
+ debugstr_a(name));
if(!GetDefaultPrinterA(buf, &dwBufLen))
return num;
i = SendDlgItemMessageA(hDlg, id, CB_FINDSTRINGEXACT, -1, (LPARAM)buf);
@@ -165,8 +166,9 @@ static INT PRINTDLG_SetUpPrinterListComboW(HWND hDlg, UINT id, LPCWSTR name)
(LPARAM)name)) == CB_ERR) {
WCHAR buf[260];
DWORD dwBufLen = sizeof(buf)/sizeof(buf[0]);
- TRACE("Can't find '%s' in printer list so trying to find default\n",
- debugstr_w(name));
+ if (name != NULL)
+ WARN("Can't find %s in printer list so trying to find default\n",
+ debugstr_w(name));
if(!GetDefaultPrinterW(buf, &dwBufLen))
return num;
i = SendDlgItemMessageW(hDlg, id, CB_FINDSTRINGEXACT, -1, (LPARAM)buf);
More information about the wine-cvs
mailing list