James Hawkins : shdocvw: Fix a test that fails on all platforms.

Alexandre Julliard julliard at winehq.org
Mon Apr 21 07:46:17 CDT 2008


Module: wine
Branch: master
Commit: 03599dbab6e7ee8fc13a340cfa24bc0b25ed2091
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=03599dbab6e7ee8fc13a340cfa24bc0b25ed2091

Author: James Hawkins <jhawkins at codeweavers.com>
Date:   Sun Apr 20 20:59:51 2008 -0500

shdocvw: Fix a test that fails on all platforms.

---

 dlls/shdocvw/tests/shortcut.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/dlls/shdocvw/tests/shortcut.c b/dlls/shdocvw/tests/shortcut.c
index 202a331..5a740dc 100644
--- a/dlls/shdocvw/tests/shortcut.c
+++ b/dlls/shdocvw/tests/shortcut.c
@@ -179,12 +179,18 @@ static void test_ShortcutFolder(void) {
     /* Convert the wszWineTestFolder string to an ITEMIDLIST. */
     hr = IShellFolder_ParseDisplayName(pDesktopFolder, NULL, NULL, wszWineTestFolder, NULL, 
                                        &pidlWineTestFolder, NULL);
-    ok (SUCCEEDED(hr), "IShellFolder::ParseDisplayName failed! hr = %08x\n", hr);
+    todo_wine
+    {
+        ok (hr == HRESULT_FROM_WIN32(ERROR_INVALID_PARAMETER),
+            "Expected %08x, got %08x\n", HRESULT_FROM_WIN32(ERROR_INVALID_PARAMETER), hr);
+    }
     if (FAILED(hr)) {
         IShellFolder_Release(pDesktopFolder);
         goto cleanup;
     }
 
+    /* FIXME: these tests are never run */
+
     /* Bind to a WineTest folder object. There has to be some support for this in shdocvw.dll.
      * This isn't implemented in wine yet.*/
     hr = IShellFolder_BindToObject(pDesktopFolder, pidlWineTestFolder, NULL, &IID_IShellFolder, 




More information about the wine-cvs mailing list