Kusanagi Kouichi : imm32: Fix a meaningless test.

Alexandre Julliard julliard at winehq.org
Thu Apr 24 06:24:12 CDT 2008


Module: wine
Branch: master
Commit: 83ae4a92e52ff7dabafad0336d587a026a1678aa
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=83ae4a92e52ff7dabafad0336d587a026a1678aa

Author: Kusanagi Kouichi <slash at ma.neweb.ne.jp>
Date:   Thu Apr 24 08:32:03 2008 +0900

imm32: Fix a meaningless test.

ImmSetCompositionString generates WM_IME_COMPOSITION. Therefore test always
fails if messages are not flushed.

---

 dlls/imm32/tests/imm32.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c
index a5d09ca..591feb3 100644
--- a/dlls/imm32/tests/imm32.c
+++ b/dlls/imm32/tests/imm32.c
@@ -191,16 +191,13 @@ static int test_ImmNotifyIME(void) {
        "WM_IME_COMPOSITION in response to NI_COMPOSITIONSTR / CPS_CANCEL, if "
        "the composition string being canceled is empty.\n");
 
+    ImmSetCompositionString(imc, SCS_SETSTR, string, sizeof(string), NULL, 0);
     msg_spy_flush_msgs();
 
-    ImmSetCompositionString(imc, SCS_SETSTR, string, sizeof(string), NULL, 0);
     ImmNotifyIME(imc, NI_COMPOSITIONSTR, CPS_CANCEL, 0);
-    todo_wine
-    {
-        ok(!msg_spy_find_msg(WM_IME_COMPOSITION), "Windows does not post "
-           "WM_IME_COMPOSITION in response to NI_COMPOSITIONSTR / CPS_CANCEL, if "
-           "the composition string being canceled is non empty.\n");
-    }
+    ok(!msg_spy_find_msg(WM_IME_COMPOSITION), "Windows does not post "
+       "WM_IME_COMPOSITION in response to NI_COMPOSITIONSTR / CPS_CANCEL, if "
+       "the composition string being canceled is non empty.\n");
 
     /* behavior differs between win9x and NT */
     ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr));




More information about the wine-cvs mailing list