Dan Kegel : shell32/tests: Test whether SHGetFileInfo should clear hIcon.
Alexandre Julliard
julliard at winehq.org
Tue Aug 5 07:26:15 CDT 2008
Module: wine
Branch: master
Commit: f0864c55eb9713966e78df5297beb3f436261a82
URL: http://source.winehq.org/git/wine.git/?a=commit;h=f0864c55eb9713966e78df5297beb3f436261a82
Author: Dan Kegel <dank at kegel.com>
Date: Mon Aug 4 15:19:02 2008 -0700
shell32/tests: Test whether SHGetFileInfo should clear hIcon.
---
dlls/shell32/tests/shlfileop.c | 75 ++++++++++++++++++++++++++++++++++++++--
1 files changed, 72 insertions(+), 3 deletions(-)
diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c
index 9b5220a..1cedcfb 100644
--- a/dlls/shell32/tests/shlfileop.c
+++ b/dlls/shell32/tests/shlfileop.c
@@ -154,19 +154,45 @@ static void clean_after_shfo_tests(void)
static void test_get_file_info(void)
{
DWORD rc, rc2;
- SHFILEINFO shfi, shfi2;
+ SHFILEINFOA shfi, shfi2;
+ SHFILEINFOW shfiw;
char notepad[MAX_PATH];
+ /* Test whether fields of SHFILEINFOA are always cleared */
+ memset(&shfi, 0xcf, sizeof(shfi));
+ rc=SHGetFileInfoA("", 0, &shfi, sizeof(shfi), 0);
+ ok(rc, "SHGetFileInfoA('' | 0) should not fail\n");
+ todo_wine ok(shfi.hIcon == 0, "SHGetFileInfoA('' | 0) did not clear hIcon\n");
+ todo_wine ok(shfi.szDisplayName[0] == 0, "SHGetFileInfoA('' | 0) did not clear szDisplayName[0]\n");
+ todo_wine ok(shfi.szTypeName[0] == 0, "SHGetFileInfoA('' | 0) did not clear szTypeName[0]\n");
+ ok(shfi.iIcon == 0xcfcfcfcf, "SHGetFileInfoA('' | 0) should not clear iIcon\n");
+ ok(shfi.dwAttributes == 0xcfcfcfcf, "SHGetFileInfoA('' | 0) should not clear dwAttributes\n");
+
+ /* Test whether fields of SHFILEINFOW are always cleared */
+ memset(&shfiw, 0xcf, sizeof(shfiw));
+ rc=SHGetFileInfoW(NULL, 0, &shfiw, sizeof(shfiw), 0);
+ todo_wine ok(!rc, "SHGetFileInfoW(NULL | 0) should fail\n");
+ ok(shfiw.hIcon == (HANDLE) 0xcfcfcfcf, "SHGetFileInfoW(NULL | 0) should not clear hIcon\n");
+ todo_wine ok(shfiw.szDisplayName[0] == 0xcfcf, "SHGetFileInfoW(NULL | 0) should not clear szDisplayName[0]\n");
+ todo_wine ok(shfiw.szTypeName[0] == 0xcfcf, "SHGetFileInfoW(NULL | 0) should not clear szTypeName[0]\n");
+ todo_wine ok(shfiw.iIcon == 0xcfcfcfcf, "SHGetFileInfoW(NULL | 0) should not clear iIcon\n");
+ ok(shfiw.dwAttributes == 0xcfcfcfcf, "SHGetFileInfoW(NULL | 0) should not clear dwAttributes\n");
+
+
/* Test some flag combinations that MSDN claims are not allowed,
* but which work anyway
*/
- shfi.dwAttributes=0xdeadbeef;
+ memset(&shfi, 0xcf, sizeof(shfi));
rc=SHGetFileInfoA("c:\\nonexistent", FILE_ATTRIBUTE_DIRECTORY,
&shfi, sizeof(shfi),
SHGFI_ATTRIBUTES | SHGFI_USEFILEATTRIBUTES);
todo_wine ok(rc, "SHGetFileInfoA(c:\\nonexistent | SHGFI_ATTRIBUTES) failed\n");
if (rc)
- ok(shfi.dwAttributes != 0xdeadbeef, "dwFileAttributes is not set\n");
+ ok(shfi.dwAttributes != 0xcfcfcfcf, "dwFileAttributes is not set\n");
+ todo_wine ok(shfi.hIcon == 0, "SHGetFileInfoA(c:\\nonexistent | SHGFI_ATTRIBUTES) did not clear hIcon\n");
+ todo_wine ok(shfi.szDisplayName[0] == 0, "SHGetFileInfoA(c:\\nonexistent | SHGFI_ATTRIBUTES) did not clear szDisplayName[0]\n");
+ todo_wine ok(shfi.szTypeName[0] == 0, "SHGetFileInfoA(c:\\nonexistent | SHGFI_ATTRIBUTES) did not clear szTypeName[0]\n");
+ ok(shfi.iIcon == 0xcfcfcfcf, "SHGetFileInfoA(c:\\nonexistent | SHGFI_ATTRIBUTES) should not clear iIcon\n");
rc=SHGetFileInfoA("c:\\nonexistent", FILE_ATTRIBUTE_DIRECTORY,
&shfi, sizeof(shfi),
@@ -230,6 +256,48 @@ static void test_get_file_info(void)
}
}
+static void test_get_file_info_iconlist(void)
+{
+ /* Test retrieving a handle to the system image list, and
+ * what that returns for hIcon
+ */
+ HRESULT hr;
+ HIMAGELIST hSysImageList;
+ LPITEMIDLIST pidList;
+ SHFILEINFOA shInfoa;
+ SHFILEINFOW shInfow;
+
+ hr = SHGetSpecialFolderLocation(NULL, CSIDL_DESKTOP, &pidList);
+ if (!SUCCEEDED(hr)) {
+ skip("can't get desktop pidl\n");
+ return;
+ }
+
+ memset(&shInfoa, 0xcf, sizeof(shInfoa));
+ hSysImageList = (HIMAGELIST) SHGetFileInfoA((const char *)pidList, 0,
+ &shInfoa, sizeof(shInfoa),
+ SHGFI_SYSICONINDEX | SHGFI_SMALLICON | SHGFI_PIDL);
+ ok(hSysImageList != INVALID_HANDLE_VALUE, "Can't get handle for CSIDL_DESKTOP imagelist\n");
+ todo_wine ok(shInfoa.hIcon == 0, "SHGetFileInfoA(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) did not clear hIcon\n");
+ todo_wine ok(shInfoa.szTypeName[0] == 0, "SHGetFileInfoA(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) did not clear szTypeName[0]\n");
+ ok(shInfoa.iIcon != 0xcfcfcfcf, "SHGetFileInfoA(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) should set iIcon\n");
+ ok(shInfoa.dwAttributes == 0xcfcfcfcf, "SHGetFileInfoA(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) should not change dwAttributes\n");
+ CloseHandle(hSysImageList);
+
+ memset(&shInfow, 0xcf, sizeof(shInfow));
+ hSysImageList = (HIMAGELIST) SHGetFileInfoW((const WCHAR *)pidList, 0,
+ &shInfow, sizeof(shInfow),
+ SHGFI_SYSICONINDEX | SHGFI_SMALLICON | SHGFI_PIDL);
+ ok(hSysImageList != INVALID_HANDLE_VALUE, "Can't get handle for CSIDL_DESKTOP imagelist\n");
+ todo_wine ok(shInfow.hIcon == 0, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) did not clear hIcon\n");
+ ok(shInfow.szTypeName[0] == 0, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) did not clear szTypeName[0]\n");
+ ok(shInfow.iIcon != 0xcfcfcfcf, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) should set iIcon\n");
+ ok(shInfow.dwAttributes == 0xcfcfcfcf, "SHGetFileInfoW(CSIDL_DESKTOP, SHGFI_SYSICONINDEX|SHGFI_SMALLICON|SHGFI_PIDL) should not change dwAttributes\n");
+ CloseHandle(hSysImageList);
+
+ ILFree(pidList);
+}
+
/*
puts into the specified buffer file names with current directory.
@@ -1447,6 +1515,7 @@ START_TEST(shlfileop)
init_shfo_tests();
test_get_file_info();
+ test_get_file_info_iconlist();
clean_after_shfo_tests();
init_shfo_tests();
More information about the wine-cvs
mailing list