James Hawkins : msi: Don' t remove a file if the old file is strictly newer than the version to be installed .

Alexandre Julliard julliard at winehq.org
Tue Aug 19 08:46:44 CDT 2008


Module: wine
Branch: master
Commit: f33ef6ac3bbd5b02fd1e2d496fcc413e30ca4f71
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f33ef6ac3bbd5b02fd1e2d496fcc413e30ca4f71

Author: James Hawkins <jhawkins at codeweavers.com>
Date:   Mon Aug 18 23:01:36 2008 -0500

msi: Don't remove a file if the old file is strictly newer than the version to be installed.

---

 dlls/msi/files.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/files.c b/dlls/msi/files.c
index 32334cd..e69c879 100644
--- a/dlls/msi/files.c
+++ b/dlls/msi/files.c
@@ -453,10 +453,10 @@ UINT ACTION_RemoveFiles( MSIPACKAGE *package )
         if ( file->state != msifs_present )
             continue;
 
-        /* only remove a file if the version to be installed
-         * is strictly newer than the old file
+        /* don't remove a file if the old file
+         * is strictly newer than the version to be installed
          */
-        if ( msi_compare_file_version( file ) >= 0 )
+        if ( msi_compare_file_version( file ) < 0 )
             continue;
 
         TRACE("removing %s\n", debugstr_w(file->File) );




More information about the wine-cvs mailing list