Michael Karcher : msxml3: Remove attach_xmldoc(This, NULL) calls.

Alexandre Julliard julliard at winehq.org
Mon Dec 1 07:34:26 CST 2008


Module: wine
Branch: master
Commit: 8b293040a370ff756beab0692ac316d720becd96
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=8b293040a370ff756beab0692ac316d720becd96

Author: Michael Karcher <wine at mkarcher.dialup.fu-berlin.de>
Date:   Sat Nov 29 10:52:16 2008 +0100

msxml3: Remove attach_xmldoc(This, NULL) calls.

This->node should never be zero. Each IXMLDOMNode (and derived interfaces)
always represents a present libxml data object. There is no no-data
IXMLDOMNode, although there might be documents without a root element.

---

 dlls/msxml3/domdoc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
index 860cd60..c8eec39 100644
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -1364,8 +1364,6 @@ static HRESULT WINAPI domdoc_load(
 
     assert( This->node );
 
-    attach_xmldoc(This->node, NULL);
-
     switch( V_VT(&xmlSource) )
     {
     case VT_BSTR:
@@ -1549,8 +1547,6 @@ static HRESULT WINAPI domdoc_loadXML(
 
     assert ( This->node );
 
-    attach_xmldoc( This->node, NULL );
-
     if ( isSuccessful )
     {
         *isSuccessful = VARIANT_FALSE;




More information about the wine-cvs mailing list