Alistair Leslie-Hughes : msxml3: Implement IXMLDOMProcessingInstruction target.

Alexandre Julliard julliard at winehq.org
Sat Feb 16 09:57:36 CST 2008


Module: wine
Branch: master
Commit: 701991ca326c47c158d85760c33b10f7550a8cad
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=701991ca326c47c158d85760c33b10f7550a8cad

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Sat Feb 16 22:02:40 2008 +1100

msxml3: Implement IXMLDOMProcessingInstruction target.

---

 dlls/msxml3/pi.c           |    5 +++--
 dlls/msxml3/tests/domdoc.c |   12 ++++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/dlls/msxml3/pi.c b/dlls/msxml3/pi.c
index 054d7f8..1129690 100644
--- a/dlls/msxml3/pi.c
+++ b/dlls/msxml3/pi.c
@@ -433,8 +433,9 @@ static HRESULT WINAPI dom_pi_get_target(
     IXMLDOMProcessingInstruction *iface,
     BSTR *p)
 {
-    FIXME("\n");
-    return E_NOTIMPL;
+    /* target returns the same value as nodeName property */
+    dom_pi *This = impl_from_IXMLDOMProcessingInstruction( iface );
+    return IXMLDOMNode_get_nodeName( This->node, p );
 }
 
 static HRESULT WINAPI dom_pi_get_data(
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index cbc7c6b..424de18 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -618,6 +618,18 @@ static void test_domdoc( void )
         ok( V_VT(&var) == VT_NULL, "incorrect dataType type\n");
         VariantClear(&var);
 
+        /* test nodeName */
+        r = IXMLDOMProcessingInstruction_get_nodeName(nodePI, &str);
+        ok(r == S_OK, "ret %08x\n", r );
+        ok( !lstrcmpW( str, _bstr_("xml") ), "incorrect nodeName string\n");
+        SysFreeString(str);
+
+        /* test Target */
+        r = IXMLDOMProcessingInstruction_get_target(nodePI, &str);
+        ok(r == S_OK, "ret %08x\n", r );
+        ok( !lstrcmpW( str, _bstr_("xml") ), "incorrect target string\n");
+        SysFreeString(str);
+
         /* test nodeTypeString */
         r = IXMLDOMProcessingInstruction_get_nodeTypeString(nodePI, &str);
         ok(r == S_OK, "ret %08x\n", r );




More information about the wine-cvs mailing list