Rob Shearman : advpack: Fix buffer overrun in convert_file_list.

Alexandre Julliard julliard at winehq.org
Tue Feb 19 08:05:16 CST 2008


Module: wine
Branch: master
Commit: 3055239f69b19a3212ab8237c2c6a92ca674d3db
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3055239f69b19a3212ab8237c2c6a92ca674d3db

Author: Rob Shearman <rob at codeweavers.com>
Date:   Mon Feb 18 19:37:27 2008 +0000

advpack: Fix buffer overrun in convert_file_list.

---

 dlls/advpack/files.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c
index f351bb4..5003239 100644
--- a/dlls/advpack/files.c
+++ b/dlls/advpack/files.c
@@ -564,9 +564,7 @@ static LPSTR convert_file_list(LPCSTR FileList, DWORD *dwNumFiles)
     dwLen = last - first + 3; /* room for double-null termination */
     szConvertedList = HeapAlloc(GetProcessHeap(), 0, dwLen);
     lstrcpynA(szConvertedList, first, dwLen - 1);
-
     szConvertedList[dwLen - 1] = '\0';
-    szConvertedList[dwLen] = '\0';
 
     /* empty list */
     if (!lstrlenA(szConvertedList))




More information about the wine-cvs mailing list