Rob Shearman : dplayx: Fix incorrect check in DirectPlayLobbyAImpl_EnumLocalApplications and IDirectPlayLobbyAImpl_EnumAddressTypes .
Alexandre Julliard
julliard at winehq.org
Fri Feb 22 05:49:29 CST 2008
Module: wine
Branch: master
Commit: 0435395ccc87b686852ae1d9a2f2a46d03952301
URL: http://source.winehq.org/git/wine.git/?a=commit;h=0435395ccc87b686852ae1d9a2f2a46d03952301
Author: Rob Shearman <rob at codeweavers.com>
Date: Thu Feb 21 16:44:34 2008 +0000
dplayx: Fix incorrect check in DirectPlayLobbyAImpl_EnumLocalApplications and IDirectPlayLobbyAImpl_EnumAddressTypes.
Dereferencing a function pointer and checking it against NULL doesn't
make any sense, so remove the checks.
---
dlls/dplayx/dplobby.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/dplayx/dplobby.c b/dlls/dplayx/dplobby.c
index f12025e..7a60602 100644
--- a/dlls/dplayx/dplobby.c
+++ b/dlls/dplayx/dplobby.c
@@ -736,7 +736,7 @@ static HRESULT WINAPI IDirectPlayLobbyAImpl_EnumAddressTypes
return DPERR_INVALIDPARAMS;
}
- if( !lpEnumAddressTypeCallback || !*lpEnumAddressTypeCallback )
+ if( !lpEnumAddressTypeCallback )
{
return DPERR_INVALIDPARAMS;
}
@@ -892,7 +892,7 @@ static HRESULT WINAPI IDirectPlayLobbyAImpl_EnumLocalApplications
return DPERR_INVALIDPARAMS;
}
- if( !lpEnumLocalAppCallback || !*lpEnumLocalAppCallback )
+ if( !lpEnumLocalAppCallback )
{
return DPERR_INVALIDPARAMS;
}
More information about the wine-cvs
mailing list