Alistair Leslie-Hughes : msxml3: Implement IXMLDOMComment_get_data.

Alexandre Julliard julliard at winehq.org
Thu Feb 28 06:21:51 CST 2008


Module: wine
Branch: master
Commit: f9d89ed36a88c047ccd32d9a6a8c031349a46f4f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f9d89ed36a88c047ccd32d9a6a8c031349a46f4f

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Thu Feb 28 21:06:54 2008 +1100

msxml3: Implement IXMLDOMComment_get_data.

---

 dlls/msxml3/comment.c      |   16 ++++++++++++++--
 dlls/msxml3/tests/domdoc.c |    6 ++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/dlls/msxml3/comment.c b/dlls/msxml3/comment.c
index 8c86f4b..203faae 100644
--- a/dlls/msxml3/comment.c
+++ b/dlls/msxml3/comment.c
@@ -474,8 +474,20 @@ static HRESULT WINAPI domcomment_get_data(
     IXMLDOMComment *iface,
     BSTR *p)
 {
-    FIXME("\n");
-    return E_NOTIMPL;
+    domcomment *This = impl_from_IXMLDOMComment( iface );
+    HRESULT hr = E_FAIL;
+    VARIANT vRet;
+
+    if(!p)
+        return E_INVALIDARG;
+
+    hr = IXMLDOMNode_get_nodeValue( This->node, &vRet );
+    if(hr == S_OK)
+    {
+        *p = V_BSTR(&vRet);
+    }
+
+    return hr;
 }
 
 static HRESULT WINAPI domcomment_put_data(
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 0930e11..2ced1cc 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -2105,6 +2105,12 @@ static void test_xmlTypes(void)
                 ok(hr == S_OK, "ret %08x\n", hr );
 
                 /* get data Tests */
+                hr = IXMLDOMComment_get_data(pComment, &str);
+                ok(hr == S_OK, "ret %08x\n", hr );
+                ok( !lstrcmpW( str, _bstr_("This &is a ; test <>\\") ), "incorrect get_data string\n");
+                SysFreeString(str);
+
+                /* get data Tests */
                 hr = IXMLDOMComment_get_nodeValue(pComment, &v);
                 ok(hr == S_OK, "ret %08x\n", hr );
                 ok( V_VT(&v) == VT_BSTR, "incorrect dataType type\n");




More information about the wine-cvs mailing list