Marcus Meissner : msxml3: Move potential NULL ptr derefs into their if () case.

Alexandre Julliard julliard at winehq.org
Fri Jan 11 07:20:20 CST 2008


Module: wine
Branch: master
Commit: 9bccd06bf91544f7137271f7973b69b5d01ea0c8
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=9bccd06bf91544f7137271f7973b69b5d01ea0c8

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Fri Jan 11 09:15:41 2008 +0100

msxml3: Move potential NULL ptr derefs into their if () case.

---

 dlls/msxml3/tests/domdoc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 8ba8609..19a3dc1 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -531,8 +531,8 @@ static void test_domdoc( void )
         r = IXMLDOMText_get_attributes( nodetext, &pAttribs);
         ok(r == S_FALSE, "ret %08x\n", r );
         ok( pAttribs == NULL, "pAttribs not NULL\n");
+        IXMLDOMText_Release( nodetext );
     }
-    IXMLDOMText_Release( nodetext );
     SysFreeString( str );
 
     /* test Create Comment */
@@ -550,8 +550,8 @@ static void test_domdoc( void )
         r = IXMLDOMComment_get_lastChild(node_comment, &nodeChild);
         ok(r == S_FALSE, "ret %08x\n", r );
         ok(nodeChild == NULL, "pLastChild not NULL\n");
+        IXMLDOMText_Release( node_comment );
     }
-    IXMLDOMText_Release( node_comment );
 
     /* test Create Attribute */
     r = IXMLDOMDocument_createAttribute(doc, NULL, NULL);
@@ -582,8 +582,8 @@ static void test_domdoc( void )
         r = IXMLDOMProcessingInstruction_get_lastChild(nodePI, &nodeChild);
         ok(r == S_FALSE, "ret %08x\n", r );
         ok(nodeChild == NULL, "nodeChild not NULL\n");
+        IXMLDOMProcessingInstruction_Release(nodePI);
     }
-    IXMLDOMProcessingInstruction_Release(nodePI);
 
     r = IXMLDOMDocument_Release( doc );
     ok( r == 0, "document ref count incorrect\n");




More information about the wine-cvs mailing list