James Hawkins : msi: Validate the szProduct parameter of MsiConfigureProductEx.

Alexandre Julliard julliard at winehq.org
Tue Jul 29 07:16:32 CDT 2008


Module: wine
Branch: master
Commit: ac976c94c822be156af719d5fe14da2cfd5ee53b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=ac976c94c822be156af719d5fe14da2cfd5ee53b

Author: James Hawkins <jhawkins at codeweavers.com>
Date:   Mon Jul 28 18:47:30 2008 -0500

msi: Validate the szProduct parameter of MsiConfigureProductEx.

---

 dlls/msi/msi.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c
index 0bd23fa..f3d6090 100644
--- a/dlls/msi/msi.c
+++ b/dlls/msi/msi.c
@@ -357,6 +357,9 @@ UINT WINAPI MsiConfigureProductExW(LPCWSTR szProduct, int iInstallLevel,
     TRACE("%s %d %d %s\n",debugstr_w(szProduct), iInstallLevel, eInstallState,
           debugstr_w(szCommandLine));
 
+    if (!szProduct || lstrlenW(szProduct) != GUID_SIZE - 1)
+        return ERROR_INVALID_PARAMETER;
+
     if (eInstallState != INSTALLSTATE_LOCAL &&
         eInstallState != INSTALLSTATE_DEFAULT)
     {




More information about the wine-cvs mailing list