Alistair Leslie-Hughes : urlmon: Check pointer before use.

Alexandre Julliard julliard at winehq.org
Fri Jun 20 06:22:48 CDT 2008


Module: wine
Branch: master
Commit: 031e1ae441d4908e7331258d2b247267906f28cf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=031e1ae441d4908e7331258d2b247267906f28cf

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Wed Jun 18 22:14:30 2008 +1000

urlmon: Check pointer before use.

---

 dlls/urlmon/tests/stream.c |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/dlls/urlmon/tests/stream.c b/dlls/urlmon/tests/stream.c
index 72a1d43..4fc96ef 100644
--- a/dlls/urlmon/tests/stream.c
+++ b/dlls/urlmon/tests/stream.c
@@ -294,7 +294,7 @@ static void create_file(void)
 static void test_URLOpenBlockingStreamW(void)
 {
     HRESULT hr;
-    IStream *pStream;
+    IStream *pStream = NULL;
     char buffer[256];
 
     hr = URLOpenBlockingStreamW(NULL, NULL, &pStream, 0, &BindStatusCallback);
@@ -324,12 +324,14 @@ static void test_URLOpenBlockingStreamW(void)
     CHECK_CALLED(OnStopBinding);
 
     ok(pStream != NULL, "pStream is NULL\n");
+    if(pStream)
+    {
+        hr = IStream_Read(pStream, buffer, sizeof(buffer), NULL);
+        ok(hr == S_OK, "IStream_Read failed with error 0x%08x\n", hr);
+        ok(!memcmp(buffer, szHtmlDoc, sizeof(szHtmlDoc)-1), "read data differs from file\n");
 
-    hr = IStream_Read(pStream, buffer, sizeof(buffer), NULL);
-    ok(hr == S_OK, "IStream_Read failed with error 0x%08x\n", hr);
-    ok(!memcmp(buffer, szHtmlDoc, sizeof(szHtmlDoc)-1), "read data differs from file\n");
-
-    IStream_Release(pStream);
+        IStream_Release(pStream);
+    }
 }
 
 static void test_URLOpenStreamW(void)




More information about the wine-cvs mailing list