James Hawkins : msi: Don' t bail out if the row to modify is not found as not all modify commands need the row .

Alexandre Julliard julliard at winehq.org
Sat Mar 1 06:13:24 CST 2008


Module: wine
Branch: master
Commit: 724c8da7343ee6b9996dac5e4b71890a9756eb72
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=724c8da7343ee6b9996dac5e4b71890a9756eb72

Author: James Hawkins <jhawkins at codeweavers.com>
Date:   Fri Feb 29 13:41:04 2008 -0600

msi: Don't bail out if the row to modify is not found as not all modify commands need the row.

---

 dlls/msi/where.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/dlls/msi/where.c b/dlls/msi/where.c
index c12f7a4..aa5d5f3 100644
--- a/dlls/msi/where.c
+++ b/dlls/msi/where.c
@@ -88,7 +88,7 @@ static UINT find_entry_in_hash(MSIHASHENTRY **table, UINT row, UINT *val)
 
     if (!(entry = table[row % MSI_HASH_TABLE_SIZE]))
     {
-        ERR("Row not found in hash table!\n");
+        WARN("Row not found in hash table!\n");
         return ERROR_FUNCTION_FAILED;
     }
 
@@ -511,10 +511,7 @@ static UINT WHERE_modify( struct tagMSIVIEW *view, MSIMODIFY eModifyMode,
     if (r != ERROR_SUCCESS)
         return r;
 
-    r = find_entry_in_hash(wv->reorder, row - 1, &row);
-    if (r != ERROR_SUCCESS)
-        return r;
-
+    find_entry_in_hash(wv->reorder, row - 1, &row);
     return wv->table->ops->modify( wv->table, eModifyMode, rec, row );
 }
 




More information about the wine-cvs mailing list