Michael Karcher : msxml3: Simplify IXMLDOMNode::removeChild.

Alexandre Julliard julliard at winehq.org
Mon Oct 6 09:35:19 CDT 2008


Module: wine
Branch: master
Commit: 3bdf45534be6eff970aab301aecab345652c218f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3bdf45534be6eff970aab301aecab345652c218f

Author: Michael Karcher <wine at mkarcher.dialup.fu-berlin.de>
Date:   Sun Oct  5 12:13:24 2008 +0200

msxml3: Simplify IXMLDOMNode::removeChild.

---

 dlls/msxml3/node.c |   11 +----------
 1 files changed, 1 insertions(+), 10 deletions(-)

diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index d9a2a0c..25ffe45 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -620,8 +620,6 @@ static HRESULT WINAPI xmlnode_removeChild(
 {
     xmlnode *This = impl_from_IXMLDOMNode( iface );
     xmlNode *child_node_ptr;
-    HRESULT hr;
-    IXMLDOMNode *child;
 
     TRACE("%p->(%p, %p)\n", This, childNode, oldChild);
 
@@ -630,22 +628,15 @@ static HRESULT WINAPI xmlnode_removeChild(
     if(oldChild)
         *oldChild = NULL;
 
-    hr = IXMLDOMNode_QueryInterface(childNode, &IID_IXMLDOMNode, (LPVOID)&child);
-    if(FAILED(hr))
-        return hr;
-
-    child_node_ptr = impl_from_IXMLDOMNode(child)->node;
+    child_node_ptr = impl_from_IXMLDOMNode(childNode)->node;
     if(child_node_ptr->parent != This->node)
     {
         WARN("childNode %p is not a child of %p\n", childNode, iface);
-        IXMLDOMNode_Release(child);
         return E_INVALIDARG;
     }
 
     xmlUnlinkNode(child_node_ptr);
 
-    IXMLDOMNode_Release(child);
-
     if(oldChild)
     {
         IXMLDOMNode_AddRef(childNode);




More information about the wine-cvs mailing list