Michael Karcher : msxml3/tests: Fix assorted memory leaks.

Alexandre Julliard julliard at winehq.org
Mon Oct 13 06:39:00 CDT 2008


Module: wine
Branch: master
Commit: f5ac0f3277951aa1e707d1ec81fb230187ca98d7
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f5ac0f3277951aa1e707d1ec81fb230187ca98d7

Author: Michael Karcher <wine at mkarcher.dialup.fu-berlin.de>
Date:   Sun Oct 12 00:03:07 2008 +0200

msxml3/tests: Fix assorted memory leaks.

---

 dlls/msxml3/tests/domdoc.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index fa82a8a..578738f 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -1410,14 +1410,12 @@ static void test_create(void)
 
     V_VT(&var) = VT_R4;
     V_R4(&var) = NODE_ELEMENT;
-    str = SysAllocString( szlc );
     r = IXMLDOMDocument_createNode( doc, var, str, NULL, &node );
     ok( r == S_OK, "returns %08x\n", r );
     if( SUCCEEDED(r) ) IXMLDOMNode_Release( node );
 
     V_VT(&var) = VT_BSTR;
     V_BSTR(&var) = SysAllocString( szOne );
-    str = SysAllocString( szlc );
     r = IXMLDOMDocument_createNode( doc, var, str, NULL, &node );
     ok( r == S_OK, "returns %08x\n", r );
     if( SUCCEEDED(r) ) IXMLDOMNode_Release( node );
@@ -1425,7 +1423,6 @@ static void test_create(void)
 
     V_VT(&var) = VT_BSTR;
     V_BSTR(&var) = SysAllocString( szOneGarbage );
-    str = SysAllocString( szlc );
     r = IXMLDOMDocument_createNode( doc, var, str, NULL, &node );
     ok( r == E_INVALIDARG, "returns %08x\n", r );
     if( SUCCEEDED(r) ) IXMLDOMNode_Release( node );
@@ -1433,7 +1430,6 @@ static void test_create(void)
 
     V_VT(&var) = VT_I4;
     V_I4(&var) = NODE_ELEMENT;
-    str = SysAllocString( szlc );
     r = IXMLDOMDocument_createNode( doc, var, str, NULL, &node );
     ok( r == S_OK, "returns %08x\n", r );
     r = IXMLDOMDocument_appendChild( doc, node, &root );
@@ -1453,6 +1449,7 @@ static void test_create(void)
     str = SysAllocString( szbs );
     r = IXMLDOMDocument_createNode( doc, var, str, NULL, &node );
     ok( r == S_OK, "returns %08x\n", r );
+    SysFreeString( str );
 
     ref = IXMLDOMNode_AddRef( node );
     ok(ref == 2, "ref = %d\n", ref);
@@ -2142,6 +2139,8 @@ static void test_XMLHTTP(void)
         ok(!memcmp(bstrResponse, wszExpectedResponse, sizeof(wszExpectedResponse)), "bstrResponse differs from what was expected\n");
         SysFreeString(bstrResponse);
     }
+
+    IXMLHttpRequest_Release(pXMLHttpRequest);
 }
 
 static void test_IXMLDOMDocument2(void)
@@ -3675,6 +3674,7 @@ static void test_testTransforms(void)
         hr = IXMLDOMDocument_transformNode(doc, pNode, &bOut);
         ok(hr == S_OK, "ret %08x\n", hr );
         ok( compareIgnoreReturns( bOut, _bstr_(szTransformOutput)), "Stylesheet output not correct\n");
+        SysFreeString(bOut);
 
         IXMLDOMNode_Release(pNode);
     }




More information about the wine-cvs mailing list