Nicolas Le Cam : shell32/tests: Fix wrong comment and update test accordingly.

Alexandre Julliard julliard at winehq.org
Tue Apr 7 09:04:40 CDT 2009


Module: wine
Branch: master
Commit: 4ea0b382657192c2f72a2101cc0f53cadd1258a7
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=4ea0b382657192c2f72a2101cc0f53cadd1258a7

Author: Nicolas Le Cam <niko.lecam at gmail.com>
Date:   Mon Apr  6 19:56:45 2009 +0200

shell32/tests: Fix wrong comment and update test accordingly.

---

 dlls/shell32/tests/shlfolder.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c
index de28267..5492b84 100644
--- a/dlls/shell32/tests/shlfolder.c
+++ b/dlls/shell32/tests/shlfolder.c
@@ -769,10 +769,6 @@ static void test_GetAttributesOf(void)
 
     /* Windows sets the SFGAO_CANLINK flag, when MyComputer is queried via the Desktop
      * folder object. It doesn't do this, if MyComputer is queried directly (see below).
-     * SFGAO_CANLINK is the same as DROPEFFECT_LINK, which MSDN says means: "Drag source
-     * should create a link to the original data". You can't create links on MyComputer on
-     * Windows, so this flag shouldn't be set. Seems like a bug in Windows. As long as nobody
-     * depends on this bug, we probably shouldn't imitate it.
      */
     dwFlags = 0xffffffff;
     hr = IShellFolder_GetAttributesOf(psfDesktop, 1, (LPCITEMIDLIST*)&pidlMyComputer, &dwFlags);
@@ -780,9 +776,10 @@ static void test_GetAttributesOf(void)
     for (i = 0, foundFlagsMatch = FALSE; !foundFlagsMatch &&
          i < sizeof(myComputerFlags) / sizeof(myComputerFlags[0]); i++)
     {
-        if (myComputerFlags[i] == (dwFlags & ~(DWORD)SFGAO_CANLINK))
+        if ((myComputerFlags[i] | SFGAO_CANLINK) == dwFlags)
             foundFlagsMatch = TRUE;
     }
+    todo_wine
     ok (foundFlagsMatch, "Wrong MyComputer attributes: %08x\n", dwFlags);
 
     hr = IShellFolder_BindToObject(psfDesktop, pidlMyComputer, NULL, &IID_IShellFolder, (LPVOID*)&psfMyComputer);




More information about the wine-cvs mailing list