James Hawkins : msi: Free the join view if we fail to create the table view .

Alexandre Julliard julliard at winehq.org
Wed Dec 16 09:41:32 CST 2009


Module: wine
Branch: master
Commit: b93c2c354471df6eab642b350cfe15b21f3d82b6
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=b93c2c354471df6eab642b350cfe15b21f3d82b6

Author: James Hawkins <truiken at gmail.com>
Date:   Tue Dec 15 18:18:40 2009 -0800

msi: Free the join view if we fail to create the table view.

---

 dlls/msi/join.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/join.c b/dlls/msi/join.c
index ef5cede..134c569 100644
--- a/dlls/msi/join.c
+++ b/dlls/msi/join.c
@@ -353,11 +353,13 @@ UINT JOIN_CreateView( MSIDATABASE *db, MSIVIEW **view, LPWSTR tables )
         if( r != ERROR_SUCCESS )
         {
             WARN("can't create table: %s\n", debugstr_w(tables));
+            msi_free(table);
             r = ERROR_BAD_QUERY_SYNTAX;
             goto end;
         }
 
-        r = table->view->ops->get_dimensions( table->view, NULL, &table->columns );
+        r = table->view->ops->get_dimensions( table->view, NULL,
+                                              &table->columns );
         if( r != ERROR_SUCCESS )
         {
             ERR("can't get table dimensions\n");




More information about the wine-cvs mailing list