James Hawkins : msi: Free the columns view if check_column_exists fails.

Alexandre Julliard julliard at winehq.org
Wed Dec 16 09:41:33 CST 2009


Module: wine
Branch: master
Commit: be1b1605f9421c363ea98fc0f8c6f9c9cece91e9
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=be1b1605f9421c363ea98fc0f8c6f9c9cece91e9

Author: James Hawkins <truiken at gmail.com>
Date:   Tue Dec 15 18:19:03 2009 -0800

msi: Free the columns view if check_column_exists fails.

---

 dlls/msi/alter.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/dlls/msi/alter.c b/dlls/msi/alter.c
index a62b13e..93d322b 100644
--- a/dlls/msi/alter.c
+++ b/dlls/msi/alter.c
@@ -125,7 +125,10 @@ static UINT alter_add_column(MSIALTERVIEW *av)
         return r;
 
     if (check_column_exists(av->db, av->colinfo->table, av->colinfo->column))
+    {
+        columns->ops->delete(columns);
         return ERROR_BAD_QUERY_SYNTAX;
+    }
 
     r = MSI_OpenQuery(av->db, &view, query, av->colinfo->table, av->colinfo->column);
     if (r == ERROR_SUCCESS)




More information about the wine-cvs mailing list