Alistair Leslie-Hughes : mshtml: Implement IHTMLStyle_get_marginLeft.
Alexandre Julliard
julliard at winehq.org
Wed Feb 18 10:15:39 CST 2009
Module: wine
Branch: master
Commit: de4f3fd4b9019ceec718395daae37f25dbdd12f5
URL: http://source.winehq.org/git/wine.git/?a=commit;h=de4f3fd4b9019ceec718395daae37f25dbdd12f5
Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date: Wed Feb 18 20:30:08 2009 +1100
mshtml: Implement IHTMLStyle_get_marginLeft.
---
dlls/mshtml/htmlstyle.c | 4 ++--
dlls/mshtml/tests/dom.c | 6 ++++++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
index 3ee3d80..84edd94 100644
--- a/dlls/mshtml/htmlstyle.c
+++ b/dlls/mshtml/htmlstyle.c
@@ -1196,8 +1196,8 @@ static HRESULT WINAPI HTMLStyle_get_margin(IHTMLStyle *iface, BSTR *p)
static HRESULT WINAPI HTMLStyle_get_marginLeft(IHTMLStyle *iface, VARIANT *p)
{
HTMLStyle *This = HTMLSTYLE_THIS(iface);
- FIXME("(%p)->(%p)\n", This, p);
- return E_NOTIMPL;
+ TRACE("(%p)->(%p)\n", This, p);
+ return get_nsstyle_attr_var(This->nsstyle, STYLEID_MARGIN_LEFT, p, 0);
}
static HRESULT WINAPI HTMLStyle_put_paddingTop(IHTMLStyle *iface, VARIANT v)
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index 1663fef..b6f6eaa 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -2454,6 +2454,12 @@ static void test_default_style(IHTMLStyle *style)
ok(V_VT(&v) == VT_BSTR, "V_VT(marginRight) = %d\n", V_VT(&v));
ok(!V_BSTR(&v), "V_BSTR(marginRight) = %s\n", dbgstr_w(V_BSTR(&v)));
+ V_VT(&v) = VT_NULL;
+ hres = IHTMLStyle_get_marginLeft(style, &v);
+ ok(hres == S_OK, "get_marginLeft failed: %08x\n", hres);
+ ok(V_VT(&v) == VT_BSTR, "V_VT(marginLeft) = %d\n", V_VT(&v));
+ ok(!V_BSTR(&v), "V_BSTR(marginLeft) = %s\n", dbgstr_w(V_BSTR(&v)));
+
str = (void*)0xdeadbeef;
hres = IHTMLStyle_get_fontFamily(style, &str);
ok(hres == S_OK, "get_fontFamily failed: %08x\n", hres);
More information about the wine-cvs
mailing list