Andrew Nguyen : msi/tests: Fix a few handle leaks.

Alexandre Julliard julliard at winehq.org
Mon Jan 19 08:58:50 CST 2009


Module: wine
Branch: master
Commit: 6d75522fb4d8379ba8de2be3a9c0cf1c70e1fff3
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6d75522fb4d8379ba8de2be3a9c0cf1c70e1fff3

Author: Andrew Nguyen <arethusa26 at gmail.com>
Date:   Sun Jan 18 04:48:05 2009 -0600

msi/tests: Fix a few handle leaks.

This was pointed out by Christoph von Wittich.

---

 dlls/msi/tests/install.c |    1 +
 dlls/msi/tests/msi.c     |    1 +
 dlls/msi/tests/package.c |    1 +
 dlls/msi/tests/source.c  |    1 +
 4 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c
index 5360284..96b85b9 100644
--- a/dlls/msi/tests/install.c
+++ b/dlls/msi/tests/install.c
@@ -1365,6 +1365,7 @@ static void get_user_sid(LPSTR *usersid)
     GetTokenInformation(token, TokenUser, buf, size, &size);
     user = (PTOKEN_USER)buf;
     pConvertSidToStringSidA(user->User.Sid, usersid);
+    CloseHandle(token);
 }
 
 static BOOL check_record(MSIHANDLE rec, UINT field, LPCSTR val)
diff --git a/dlls/msi/tests/msi.c b/dlls/msi/tests/msi.c
index fba584d..da89faa 100644
--- a/dlls/msi/tests/msi.c
+++ b/dlls/msi/tests/msi.c
@@ -525,6 +525,7 @@ static void get_user_sid(LPSTR *usersid)
     GetTokenInformation(token, TokenUser, buf, size, &size);
     user = (PTOKEN_USER)buf;
     pConvertSidToStringSidA(user->User.Sid, usersid);
+    CloseHandle(token);
 }
 
 static void test_MsiQueryProductState(void)
diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c
index 66ff3f0..04ad64c 100644
--- a/dlls/msi/tests/package.c
+++ b/dlls/msi/tests/package.c
@@ -51,6 +51,7 @@ static void get_user_sid(LPSTR *usersid)
     GetTokenInformation(token, TokenUser, buf, size, &size);
     user = (PTOKEN_USER)buf;
     pConvertSidToStringSidA(user->User.Sid, usersid);
+    CloseHandle(token);
 }
 
 /* RegDeleteTreeW from dlls/advapi32/registry.c */
diff --git a/dlls/msi/tests/source.c b/dlls/msi/tests/source.c
index 2eb5f18..5e21d67 100644
--- a/dlls/msi/tests/source.c
+++ b/dlls/msi/tests/source.c
@@ -139,6 +139,7 @@ static int get_user_sid(LPSTR *usersid)
     GetTokenInformation(token, TokenUser, buf, size, &size);
     user = (PTOKEN_USER)buf;
     pConvertSidToStringSidA(user->User.Sid, usersid);
+    CloseHandle(token);
     return 1;
 }
 




More information about the wine-cvs mailing list