Rob Shearman : rpcrt4: Remove the NDR version check from NdrClientCall2 and NdrStubCall2.

Alexandre Julliard julliard at winehq.org
Fri Jan 23 10:07:01 CST 2009


Module: wine
Branch: master
Commit: bcca81f4f44485e9f846e10824d23f397a2bc2b4
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=bcca81f4f44485e9f846e10824d23f397a2bc2b4

Author: Rob Shearman <robertshearman at gmail.com>
Date:   Fri Jan 23 15:09:42 2009 +0000

rpcrt4: Remove the NDR version check from NdrClientCall2 and NdrStubCall2.

It does more harm than good, since we can't get any information about
what new features are being used by the caller, if any, by bailing at
this early point.

---

 dlls/rpcrt4/ndr_stubless.c |   14 ++------------
 1 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/dlls/rpcrt4/ndr_stubless.c b/dlls/rpcrt4/ndr_stubless.c
index 9833483..645a0ca 100644
--- a/dlls/rpcrt4/ndr_stubless.c
+++ b/dlls/rpcrt4/ndr_stubless.c
@@ -583,12 +583,7 @@ LONG_PTR WINAPIV NdrClientCall2(PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pForma
 
     TRACE("pStubDesc %p, pFormat %p, ...\n", pStubDesc, pFormat);
 
-    /* Later NDR language versions probably won't be backwards compatible */
-    if (pStubDesc->Version > 0x50002)
-    {
-        FIXME("Incompatible stub description version: 0x%x\n", pStubDesc->Version);
-        RpcRaiseException(RPC_X_WRONG_STUB_VERSION);
-    }
+    TRACE("NDR Version: 0x%x\n", pStubDesc->Version);
 
     if (pProcHeader->Oi_flags & RPC_FC_PROC_OIF_RPCFLAGS)
     {
@@ -1293,12 +1288,7 @@ LONG WINAPI NdrStubCall2(
     pFormat = pServerInfo->ProcString + pServerInfo->FmtStringOffset[pRpcMsg->ProcNum];
     pProcHeader = (const NDR_PROC_HEADER *)&pFormat[0];
 
-    /* Later NDR language versions probably won't be backwards compatible */
-    if (pStubDesc->Version > 0x50002)
-    {
-        FIXME("Incompatible stub description version: 0x%x\n", pStubDesc->Version);
-        RpcRaiseException(RPC_X_WRONG_STUB_VERSION);
-    }
+    TRACE("NDR Version: 0x%x\n", pStubDesc->Version);
 
     /* create the full pointer translation tables, if requested */
     if (pProcHeader->Oi_flags & RPC_FC_PROC_OIF_FULLPTR)




More information about the wine-cvs mailing list