Hans Leidekker : wininet: Don' t delete the cache file when closing a request.

Alexandre Julliard julliard at winehq.org
Tue Jun 23 10:02:45 CDT 2009


Module: wine
Branch: master
Commit: aa05f97fc9d1485d5f4fd47bc656a7324e945d0c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=aa05f97fc9d1485d5f4fd47bc656a7324e945d0c

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Tue Jun 23 09:36:07 2009 +0200

wininet: Don't delete the cache file when closing a request.

---

 dlls/wininet/http.c       |    5 +----
 dlls/wininet/tests/http.c |    2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index e1a7ddc..6b3fb9a 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -1492,10 +1492,7 @@ static void HTTPREQ_Destroy(WININETHANDLEHEADER *hdr)
     if(lpwhr->hCacheFile)
         CloseHandle(lpwhr->hCacheFile);
 
-    if(lpwhr->lpszCacheFile) {
-        DeleteFileW(lpwhr->lpszCacheFile); /* FIXME */
-        HeapFree(GetProcessHeap(), 0, lpwhr->lpszCacheFile);
-    }
+    HeapFree(GetProcessHeap(), 0, lpwhr->lpszCacheFile);
 
     DeleteCriticalSection( &lpwhr->read_section );
     WININET_Release(&lpwhr->lpHttpSession->hdr);
diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c
index ba72629..f7994c5 100644
--- a/dlls/wininet/tests/http.c
+++ b/dlls/wininet/tests/http.c
@@ -1146,7 +1146,7 @@ static void test_http_cache(void)
 
     file = CreateFile(file_name, GENERIC_READ, FILE_SHARE_READ|FILE_SHARE_WRITE, NULL, OPEN_EXISTING,
                       FILE_ATTRIBUTE_NORMAL, NULL);
-    todo_wine ok(file != INVALID_HANDLE_VALUE, "Could not create file: %u\n", GetLastError());
+    ok(file != INVALID_HANDLE_VALUE, "Could not create file: %u\n", GetLastError());
     CloseHandle(file);
 
     request = HttpOpenRequestA(connect, NULL, "/", NULL, NULL, types, INTERNET_FLAG_NO_CACHE_WRITE, 0);




More information about the wine-cvs mailing list