Francois Gouget : winemenubuilder: Fix an off-by-one check that resulted in erroneous error messages.

Alexandre Julliard julliard at winehq.org
Thu Mar 12 09:54:21 CDT 2009


Module: wine
Branch: master
Commit: 9b6d3676a00cdeab846e54d006df4e04b6170ca3
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=9b6d3676a00cdeab846e54d006df4e04b6170ca3

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Mar 11 17:16:41 2009 +0100

winemenubuilder: Fix an off-by-one check that resulted in erroneous error messages.

---

 programs/winemenubuilder/winemenubuilder.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c
index f5f7ec0..69303c7 100644
--- a/programs/winemenubuilder/winemenubuilder.c
+++ b/programs/winemenubuilder/winemenubuilder.c
@@ -480,7 +480,7 @@ static BOOL extract_icon32(LPCWSTR szFileName, int nIndex, char *szXPMFileName)
         sEnumRes.nIndex = nIndex;
         if (!EnumResourceNamesW(hModule, (LPCWSTR)RT_GROUP_ICON,
                                 EnumResNameProc, (LONG_PTR)&sEnumRes) &&
-            sEnumRes.nIndex != 0)
+            sEnumRes.nIndex != -1)
         {
             WINE_TRACE("EnumResourceNamesW failed, error %d\n", GetLastError());
         }




More information about the wine-cvs mailing list