Michael Stefaniuc : d3dxof: Remove redundant NULL check before HeapFree ( Smatch).

Alexandre Julliard julliard at winehq.org
Thu Mar 26 11:05:45 CDT 2009


Module: wine
Branch: master
Commit: 289dca2e0e5f132cb15917fa191a140487e15fb1
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=289dca2e0e5f132cb15917fa191a140487e15fb1

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Wed Mar 25 23:02:42 2009 +0100

d3dxof: Remove redundant NULL check before HeapFree (Smatch).

---

 dlls/d3dxof/d3dxof.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/d3dxof/d3dxof.c b/dlls/d3dxof/d3dxof.c
index 6f9b266..5d42d53 100644
--- a/dlls/d3dxof/d3dxof.c
+++ b/dlls/d3dxof/d3dxof.c
@@ -1100,9 +1100,8 @@ static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetNextDataObject(IDirectXFileE
 error:
 
   HeapFree(GetProcessHeap(), 0, This->buf.pxo_tab);
+  HeapFree(GetProcessHeap(), 0, This->buf.pxo->pdata);
   HeapFree(GetProcessHeap(), 0, pstrings);
-  if (This->buf.pxo->pdata)
-    HeapFree(GetProcessHeap(), 0, This->buf.pxo->pdata);
 
   return hr;
 }




More information about the wine-cvs mailing list