Hans Leidekker : msi: Don't duplicate the table name in CREATE_CreateView.

Alexandre Julliard julliard at winehq.org
Thu May 28 09:39:47 CDT 2009


Module: wine
Branch: master
Commit: 5922de46dec881d59cc7ea2383c763538dedd87b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5922de46dec881d59cc7ea2383c763538dedd87b

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Thu May 28 15:03:19 2009 +0200

msi: Don't duplicate the table name in CREATE_CreateView.

The table name is tracked in the list attached to the parent query object,
which is destroyed after the view object.

This plugs a leak since the duplicated table name was never freed.

---

 dlls/msi/create.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/create.c b/dlls/msi/create.c
index 89d3288..63cd373 100644
--- a/dlls/msi/create.c
+++ b/dlls/msi/create.c
@@ -180,7 +180,7 @@ UINT CREATE_CreateView( MSIDATABASE *db, MSIVIEW **view, LPCWSTR table,
     for( col = col_info; col; col = col->next )
     {
         if (!col->table)
-            col->table = strdupW(table);
+            col->table = table;
 
         if( !col->temporary )
             temp = FALSE;




More information about the wine-cvs mailing list