Hans Leidekker : msi: Get rid of some redundant initializations.

Alexandre Julliard julliard at winehq.org
Mon Oct 19 09:56:13 CDT 2009


Module: wine
Branch: master
Commit: 534f20bc49741a271df10ef5353de3f4c52ef3a7
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=534f20bc49741a271df10ef5353de3f4c52ef3a7

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Mon Oct 19 11:14:20 2009 +0200

msi: Get rid of some redundant initializations.

---

 dlls/msi/database.c |    2 --
 dlls/msi/msiquery.c |    2 --
 dlls/msi/package.c  |    9 ---------
 dlls/msi/preview.c  |    1 -
 dlls/msi/suminfo.c  |    1 -
 5 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/dlls/msi/database.c b/dlls/msi/database.c
index 4db7c01..8d0ee42 100644
--- a/dlls/msi/database.c
+++ b/dlls/msi/database.c
@@ -191,8 +191,6 @@ UINT MSI_OpenDatabaseW(LPCWSTR szDBPath, LPCWSTR szPersist, MSIDATABASE **pdb)
     db->mode = szMode;
     if (created)
         db->deletefile = strdupW( szDBPath );
-    else
-        db->deletefile = NULL;
     list_init( &db->tables );
     list_init( &db->transforms );
 
diff --git a/dlls/msi/msiquery.c b/dlls/msi/msiquery.c
index 5a46f9b..b973382 100644
--- a/dlls/msi/msiquery.c
+++ b/dlls/msi/msiquery.c
@@ -126,9 +126,7 @@ UINT MSI_DatabaseOpenViewW(MSIDATABASE *db,
         return ERROR_FUNCTION_FAILED;
 
     msiobj_addref( &db->hdr );
-    query->row = 0;
     query->db = db;
-    query->view = NULL;
     list_init( &query->mem );
 
     r = MSI_ParseSQL( db, szQuery, &query->view, &query->mem );
diff --git a/dlls/msi/package.c b/dlls/msi/package.c
index 9c92842..fa0cd6f 100644
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -744,15 +744,6 @@ static MSIPACKAGE *msi_alloc_package( void )
         list_init( &package->RunningActions );
         list_init( &package->sourcelist_info );
         list_init( &package->sourcelist_media );
-
-        package->patch = NULL;
-        package->ActionFormat = NULL;
-        package->LastAction = NULL;
-        package->dialog = NULL;
-        package->next_dialog = NULL;
-        package->scheduled_action_running = FALSE;
-        package->commit_action_running = FALSE;
-        package->rollback_action_running = FALSE;
     }
 
     return package;
diff --git a/dlls/msi/preview.c b/dlls/msi/preview.c
index a2b3f32..458e4a1 100644
--- a/dlls/msi/preview.c
+++ b/dlls/msi/preview.c
@@ -54,7 +54,6 @@ static MSIPREVIEW *MSI_EnableUIPreview( MSIDATABASE *db )
         if( preview )
         {
             preview->package = package;
-            preview->dialog = 0;
             msiobj_addref( &package->hdr );
         }
         msiobj_release( &package->hdr );
diff --git a/dlls/msi/suminfo.c b/dlls/msi/suminfo.c
index ef16665..d3db44a 100644
--- a/dlls/msi/suminfo.c
+++ b/dlls/msi/suminfo.c
@@ -443,7 +443,6 @@ MSISUMMARYINFO *MSI_GetSummaryInformationW( IStorage *stg, UINT uiUpdateCount )
     if( !si )
         return si;
 
-    memset( si->property, 0, sizeof si->property );
     si->update_count = uiUpdateCount;
     IStorage_AddRef( stg );
     si->storage = stg;




More information about the wine-cvs mailing list