Paul Vriens : advapi32/tests: Add a input parameter check (CloseEventLog).

Alexandre Julliard julliard at winehq.org
Tue Oct 27 09:46:34 CDT 2009


Module: wine
Branch: master
Commit: 4af8e5f24d8e4cc214b5f68dc770c6e3fc444b9b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=4af8e5f24d8e4cc214b5f68dc770c6e3fc444b9b

Author: Paul Vriens <Paul.Vriens.Wine at gmail.com>
Date:   Tue Oct 27 10:37:07 2009 +0100

advapi32/tests: Add a input parameter check (CloseEventLog).

---

 dlls/advapi32/eventlog.c       |   11 +++++++++--
 dlls/advapi32/tests/eventlog.c |    3 ---
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/dlls/advapi32/eventlog.c b/dlls/advapi32/eventlog.c
index 495623c..1074ccc 100644
--- a/dlls/advapi32/eventlog.c
+++ b/dlls/advapi32/eventlog.c
@@ -125,8 +125,15 @@ BOOL WINAPI ClearEventLogW( HANDLE hEventLog, LPCWSTR lpBackupFileName )
  */
 BOOL WINAPI CloseEventLog( HANDLE hEventLog )
 {
-	FIXME("(%p) stub\n", hEventLog);
-	return TRUE;
+    FIXME("(%p) stub\n", hEventLog);
+
+    if (!hEventLog)
+    {
+        SetLastError(ERROR_INVALID_HANDLE);
+        return FALSE;
+    }
+
+    return TRUE;
 }
 
 /******************************************************************************
diff --git a/dlls/advapi32/tests/eventlog.c b/dlls/advapi32/tests/eventlog.c
index 9fdf745..2823f17 100644
--- a/dlls/advapi32/tests/eventlog.c
+++ b/dlls/advapi32/tests/eventlog.c
@@ -34,13 +34,10 @@ static void test_open_close(void)
 
     SetLastError(0xdeadbeef);
     ret = CloseEventLog(NULL);
-    todo_wine
-    {
     ok(!ret, "Expected failure\n");
     ok(GetLastError() == ERROR_INVALID_HANDLE ||
        GetLastError() == ERROR_NOACCESS, /* W2K */
        "Expected ERROR_INVALID_HANDLE, got %d\n", GetLastError());
-    }
 
     SetLastError(0xdeadbeef);
     handle = OpenEventLogA(NULL, NULL);




More information about the wine-cvs mailing list