Andrew Bogott : ole32: Fix an off-by-one error that broke reading of many properties.

Alexandre Julliard julliard at winehq.org
Wed Dec 1 12:56:46 CST 2010


Module: wine
Branch: master
Commit: c75a4fd50a03495d661fdb6751b52d1828a7aabc
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c75a4fd50a03495d661fdb6751b52d1828a7aabc

Author: Andrew Bogott <andrew at CodeWeavers.com>
Date:   Sat Nov 20 13:43:01 2010 -0600

ole32: Fix an off-by-one error that broke reading of many properties.

---

 dlls/ole32/stg_prop.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/ole32/stg_prop.c b/dlls/ole32/stg_prop.c
index b3362bc..65b4b2e 100644
--- a/dlls/ole32/stg_prop.c
+++ b/dlls/ole32/stg_prop.c
@@ -1356,7 +1356,7 @@ static HRESULT PropertyStorage_ReadFromStream(PropertyStorage_impl *This)
          i * sizeof(PROPERTYIDOFFSET));
 
         if (idOffset->dwOffset < sizeof(PROPERTYSECTIONHEADER) ||
-         idOffset->dwOffset >= sectionHdr.cbSection - sizeof(DWORD))
+         idOffset->dwOffset > sectionHdr.cbSection - sizeof(DWORD))
             hr = STG_E_INVALIDPOINTER;
         else
         {




More information about the wine-cvs mailing list