Andrew Nguyen : shdocvw: Avoid a double free in PersistFile_Load.

Alexandre Julliard julliard at winehq.org
Tue Dec 7 10:59:30 CST 2010


Module: wine
Branch: master
Commit: 1c5101506821591488755c72be89c37a176a5f0e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=1c5101506821591488755c72be89c37a176a5f0e

Author: Andrew Nguyen <anguyen at codeweavers.com>
Date:   Tue Dec  7 03:12:29 2010 -0600

shdocvw: Avoid a double free in PersistFile_Load.

Spotted with Valgrind.

---

 dlls/shdocvw/intshcut.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/shdocvw/intshcut.c b/dlls/shdocvw/intshcut.c
index e400f0d..e209e04 100644
--- a/dlls/shdocvw/intshcut.c
+++ b/dlls/shdocvw/intshcut.c
@@ -526,7 +526,7 @@ static HRESULT WINAPI PersistFile_Load(IPersistFile *pFile, LPCOLESTR pszFileNam
                     TRACE("Failed to store the iconindex to our property storage.  hr = 0x%x\n", hr);
                 }
 
-                CoTaskMemFree(iconfile);
+                CoTaskMemFree(iconindexstring);
             }
 
             IPropertyStorage_Release(pPropStg);




More information about the wine-cvs mailing list