Jacek Caban : mshtml: Added tests showing that we should return E_NOTIMPL in DeleteMemberByName.

Alexandre Julliard julliard at winehq.org
Thu Feb 11 11:08:31 CST 2010


Module: wine
Branch: master
Commit: 0216974a1b0086211125e1b7787bc2c98252c61f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0216974a1b0086211125e1b7787bc2c98252c61f

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Thu Feb 11 01:20:26 2010 +0100

mshtml: Added tests showing that we should return E_NOTIMPL in DeleteMemberByName.

---

 dlls/mshtml/dispex.c       |    5 ++++-
 dlls/mshtml/tests/script.c |    9 +++++++++
 2 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c
index 52d8d41..4b1bd88 100644
--- a/dlls/mshtml/dispex.c
+++ b/dlls/mshtml/dispex.c
@@ -983,7 +983,10 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc
 static HRESULT WINAPI DispatchEx_DeleteMemberByName(IDispatchEx *iface, BSTR bstrName, DWORD grfdex)
 {
     DispatchEx *This = DISPATCHEX_THIS(iface);
-    FIXME("(%p)->(%s %x)\n", This, debugstr_w(bstrName), grfdex);
+
+    TRACE("(%p)->(%s %x)\n", This, debugstr_w(bstrName), grfdex);
+
+    /* Not implemented by IE */
     return E_NOTIMPL;
 }
 
diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c
index fae49c8..6a0cbe3 100644
--- a/dlls/mshtml/tests/script.c
+++ b/dlls/mshtml/tests/script.c
@@ -1803,6 +1803,11 @@ static HRESULT WINAPI ActiveScriptParse_ParseScriptText(IActiveScriptParse *ifac
 
     test_func(dispex);
     test_nextdispid(dispex);
+
+    tmp = a2bstr("test");
+    hres = IDispatchEx_DeleteMemberByName(dispex, tmp, fdexNameCaseSensitive);
+    ok(hres == E_NOTIMPL, "DeleteMemberByName failed: %08x\n", hres);
+
     IDispatchEx_Release(dispex);
 
     script_disp = (IDispatch*)&scriptDisp;
@@ -1843,6 +1848,10 @@ static HRESULT WINAPI ActiveScriptParse_ParseScriptText(IActiveScriptParse *ifac
     CHECK_CALLED(script_testprop2_d);
     SysFreeString(tmp);
 
+    tmp = a2bstr("test");
+    hres = IDispatchEx_DeleteMemberByName(window_dispex, tmp, fdexNameCaseSensitive);
+    ok(hres == E_NOTIMPL, "DeleteMemberByName failed: %08x\n", hres);
+
     test_global_id();
 
     test_security();




More information about the wine-cvs mailing list