Marcus Meissner : gdiplus: Dereference texture after checking it for NULL ( Coverity).

Alexandre Julliard julliard at winehq.org
Tue Feb 16 11:44:41 CST 2010


Module: wine
Branch: master
Commit: 21b90492316314cba03a181918f2bae58ea4eea8
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=21b90492316314cba03a181918f2bae58ea4eea8

Author: Marcus Meissner <meissner at suse.de>
Date:   Tue Feb 16 11:54:48 2010 +0100

gdiplus: Dereference texture after checking it for NULL (Coverity).

---

 dlls/gdiplus/brush.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/gdiplus/brush.c b/dlls/gdiplus/brush.c
index c867f91..abcc47f 100644
--- a/dlls/gdiplus/brush.c
+++ b/dlls/gdiplus/brush.c
@@ -801,11 +801,11 @@ GpStatus WINGDIPAPI GdipCreateTextureIA(GpImage *image,
     TRACE("(%p, %p, %.2f, %.2f, %.2f, %.2f, %p)\n", image, imageattr, x, y, width, height,
            texture);
 
-    *texture = NULL;
-
     if(!image || !texture || x < 0.0 || y < 0.0 || width < 0.0 || height < 0.0)
         return InvalidParameter;
 
+    *texture = NULL;
+
     if(image->type != ImageTypeBitmap){
         FIXME("not implemented for image type %d\n", image->type);
         return NotImplemented;




More information about the wine-cvs mailing list