Vincent Povirk : ole32: IStorage_Revert has no effect for non-transacted storages.

Alexandre Julliard julliard at winehq.org
Mon Jan 25 11:21:06 CST 2010


Module: wine
Branch: master
Commit: da250c9afeed64395349cc2fc116fbe92f9cd28a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=da250c9afeed64395349cc2fc116fbe92f9cd28a

Author: Vincent Povirk <vincent at codeweavers.com>
Date:   Sun Jan 24 13:11:51 2010 -0600

ole32: IStorage_Revert has no effect for non-transacted storages.

---

 dlls/ole32/storage32.c       |    4 ++--
 dlls/ole32/tests/storage32.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c
index 39ed710..8fe0542 100644
--- a/dlls/ole32/storage32.c
+++ b/dlls/ole32/storage32.c
@@ -1796,8 +1796,8 @@ static HRESULT WINAPI StorageImpl_Commit(
 static HRESULT WINAPI StorageImpl_Revert(
   IStorage* iface)
 {
-  FIXME("(%p): stub\n", iface);
-  return E_NOTIMPL;
+  TRACE("(%p)\n", iface);
+  return S_OK;
 }
 
 /*************************************************************************
diff --git a/dlls/ole32/tests/storage32.c b/dlls/ole32/tests/storage32.c
index ceca756..e598fe0 100644
--- a/dlls/ole32/tests/storage32.c
+++ b/dlls/ole32/tests/storage32.c
@@ -1384,7 +1384,7 @@ static void test_revert(void)
     ok(r==S_OK, "IStorage->CreateStream failed\n");
 
     r = IStorage_Revert(stg);
-    todo_wine ok(r==S_OK, "IStorage->Revert failed %08x\n", r);
+    ok(r==S_OK, "IStorage->Revert failed %08x\n", r);
 
     r = IStream_Write(stm, "this works\n", 11, NULL);
     ok(r==S_OK, "IStream_Write should succeed %08x\n", r);




More information about the wine-cvs mailing list