Greg Geldorp : msvcrt/tests: ecvt on Win9x and NT4 will corrupt memory if nrdigits < 0.

Alexandre Julliard julliard at winehq.org
Mon Jul 19 11:05:37 CDT 2010


Module: wine
Branch: master
Commit: 913c91fd470f08342f2c07bbaee6cab362e55d3e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=913c91fd470f08342f2c07bbaee6cab362e55d3e

Author: Greg Geldorp <ggeldorp at vmware.com>
Date:   Mon Jul 19 13:24:53 2010 +0200

msvcrt/tests: ecvt on Win9x and NT4 will corrupt memory if nrdigits < 0.

---

 dlls/msvcrt/tests/printf.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c
index 19e21f9..4386bf1 100644
--- a/dlls/msvcrt/tests/printf.c
+++ b/dlls/msvcrt/tests/printf.c
@@ -713,6 +713,8 @@ static void test_fcvt(void)
     ok( 0 == sign, "sign wrong\n");
 }
 
+/* Don't test nrdigits < 0, msvcrt on Win9x and NT4 will corrupt memory by
+ * writing outside allocated memory */
 static struct {
     double value;
     int nrdigits;
@@ -725,7 +727,6 @@ static struct {
     {          45.0,   2,        "45",           "4500",          2,      2,      0 },
     /* Numbers less than 1.0 with different precisions */
     {        0.0001,   1,         "1",               "",         -3,     -3,     0 },
-    {        0.0001, -10,          "",               "",         -3,     -3,     0 },
     {        0.0001,  10,"1000000000",        "1000000",         -3,     -3,     0 },
     /* Basic sign test */
     {     -111.0001,   5,     "11100",       "11100010",          3,      3,     1 },




More information about the wine-cvs mailing list