Stefan Dösinger : wined3d: Don' t use GL_ARB_map_buffer_range for now.

Alexandre Julliard julliard at winehq.org
Mon May 10 11:59:15 CDT 2010


Module: wine
Branch: master
Commit: 481aca47ad649297e5435d0f4c7466fd70aa702f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=481aca47ad649297e5435d0f4c7466fd70aa702f

Author: Stefan Dösinger <stefan at e195-194.eduroam.tuwien.ac.at>
Date:   Wed May  5 13:02:07 2010 +0200

wined3d: Don't use GL_ARB_map_buffer_range for now.

There are numerous problems with this extension, and there are no
visible upsides. In the best case dynamic VBOs are just as fast as no
VBO at all.

---

 dlls/wined3d/buffer.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/wined3d/buffer.c b/dlls/wined3d/buffer.c
index b56895b..8372b7a 100644
--- a/dlls/wined3d/buffer.c
+++ b/dlls/wined3d/buffer.c
@@ -1474,7 +1474,8 @@ HRESULT buffer_init(struct wined3d_buffer *buffer, IWineD3DDeviceImpl *device,
     TRACE("size %#x, usage %#x, format %s, memory @ %p, iface @ %p.\n", buffer->resource.size, buffer->resource.usage,
             debug_d3dformat(buffer->resource.format_desc->format), buffer->resource.allocatedMemory, buffer);
 
-    dynamic_buffer_ok = gl_info->supported[APPLE_FLUSH_BUFFER_RANGE] || gl_info->supported[ARB_MAP_BUFFER_RANGE];
+    /* GL_ARB_map_buffer_range is disabled for now due to numerous bugs and no gains */
+    dynamic_buffer_ok = gl_info->supported[APPLE_FLUSH_BUFFER_RANGE];
 
     /* Observations show that drawStridedSlow is faster on dynamic VBs than converting +
      * drawStridedFast (half-life 2 and others).




More information about the wine-cvs mailing list